bitcoindevkit / bdk_wallet / 16215822724

85%

Build Type

push

github

Committed by evanlinjin

Commit Message

Merge bitcoindevkit/bdk_wallet#277: clippy!: `Box` large enum variants

<a class=hub.com/bitcoindevkit/bdk_wallet/commit/650c3eeb142e1442a917f81cb63be9b62b73ff2b">650c3eeb1 fix!: `Box` large enum variants (valued mammal)

Pull request description:

  ### Description

  This is a fix to address clippy lints

  - `clippy::large_enum_variant`
  - `clippy::result_large_error`

  BREAKING: The types `LoadMismatch`, and `CreateWithPersistError` are changed as a result of the now boxed variants.

  fixes #245

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

  #### Bugfixes:

  * [x] This pull request breaks the existing API
  * [ ] I've added tests to reproduce the issue which are now passing
  * [ ] I'm linking the issue being fixed by this PR

ACKs for top commit:
  evanlinjin:
    ACK 650c3eeb142e1442a917f81cb63be9b62b73ff2b

Tree-SHA512: 3634425498414ea95e95f6beaa2e0033de0

Run Details

4 of 13 new or added lines in 2 files covered. (30.77%)

1 existing line in 1 file now uncovered.

6577 of 7766 relevant lines covered (84.69%)

3529.57 hits per line