safe-global / safe-client-gateway / 16213806110

89%

push

github

feat(staking): Add Kiln rewards fee endpoint + update `deployments` response (#2641)

* feat(staking): Add rewards fee endpoint + use it in NativeStakingMapper

- Introduced `RewardsFee` entity and schema for managing rewards fees.
- Implemented `getRewardsFee` method in both `StakingRepository` and `EarnRepository` to fetch rewards fee data.
- Updated `NativeStakingMapper` to utilize the new rewards fee in transaction calculations.
- Added tests for `RewardsFeeSchema` to ensure proper validation of rewards fee objects.

* test(staking): Add unit tests for getRewardsFee method

- Implemented tests for the new `getRewardsFee` method in `KilnApi` to verify correct fee retrieval and error handling.
- Introduced `rewardsFeeBuilder` for creating mock rewards fee data in tests.

* refactor(staking): Remove product_fee from DeploymentSchema and related tests

- Removed the `product_fee` field from the `DeploymentSchema` and updated the `deploymentBuilder` accordingly.
- Adjusted tests in `deployment.entity.spec.ts` to reflect the removal of `product_fee` validation.
- Updated references in transaction controllers to utilize `rewardsFee` instead of `product_fee` for fee calculations.
- Enhanced `NativeStakingMapper` and related tests to incorporate the new rewards fee structure.

* fix: remove unnecessary checks

* test(kiln-api): Remove redundant call count checks in rewards fee tests

* refactor: Simplify fee assignment

* test: restore accidently removed test case

* fix: set rewards fee default value to zero in schema

* refactor(earn): Remove getRewardsFee method from EarnRepository and update interface

* fix: Correct fee assignment by removing unary plus operator from rewards fee

* fix: update RewardsFeeSchema to allow null values for fee

* refactor: Introduce IStakingRepositoryWithRewardsFee interface

- Removed the optional getRewardsFee method from IStakingRepository and created a new interface IStakingRepositoryWithRewardsFee that includes this m... (continued)

3467 of 4239 branches covered (81.79%)

Branch coverage included in aggregate %.

20 of 20 new or added lines in 8 files covered. (100.0%)

11980 of 12984 relevant lines covered (92.27%)

547.81 hits per line