tari-project / tari / 16200110666
62%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 718
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 58.097% (-6.2%) from 64.296%
16200110666

push

github

web-flow 
chore: fix tests (#7300)

Description
---
removes uncalled tests,
fixes some tests

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Added the ability to save the last scanned blockchain height in the
output manager's storage backend.

* **Refactor**
* Generalized wallet service initializers to support custom HTTP client
factories, improving flexibility for connectivity and transaction
services.
* Updated wallet startup and service initialization to use new generic
parameters for HTTP client factories.

* **Bug Fixes**
* Corrected balance assertions in tests to reflect updated time-locked
balance handling.
* Fixed the `submit_transaction` method in the HTTP base node mock to
return a valid response.

* **Tests**
* Removed comprehensive test suites for transaction protocols and UTXO
scanner services.
* Updated and streamlined test setups to match new service initializer
signatures and database usage.
  * Marked a broken transaction service test as ignored.
* Removed unused module declarations and imports in integration and
wallet tests.

* **Chores**
* Removed deprecated FFI function and related wallet methods for adding
base node peers.
* Removed step definitions related to ffi wallet lifecycle and
connectivity management in integration tests.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

0 of 33 new or added lines in 6 files covered. (0.0%)

7429 existing lines in 95 files now uncovered.

69707 of 119984 relevant lines covered (58.1%)

226952.75 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
0.0
 -22.79% base_layer/wallet/src/transaction_service/service.rs
3
0.0
 -90.32% base_layer/wallet/src/output_manager_service/mod.rs
3
0.0
 -88.67% base_layer/wallet/src/transaction_service/mod.rs
7
0.0
 -89.29% base_layer/wallet/src/base_node_service/mod.rs
7
12.95
 -46.19% base_layer/wallet/src/output_manager_service/storage/sqlite_db/mod.rs
12
0.0
 0.0% base_layer/wallet/src/wallet.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
70.87
 -0.97% base_layer/service_framework/src/context/handles.rs
1
91.23
 -1.75% base_layer/wallet/src/output_manager_service/storage/sqlite_db/new_output_sql.rs
1
86.36
 -4.55% common_sqlite/src/connection_options.rs
1
26.56
 -1.56% comms/dht/src/outbound/message.rs
1
91.36
 -0.45% comms/dht/src/outbound/message_send_state.rs
2
0.0
 -13.33% base_layer/core/src/base_node/rpc/mod.rs
2
94.78
 -1.49% base_layer/service_framework/src/reply_channel.rs
3
73.21
 -5.36% base_layer/core/src/base_node/proto/chain_metadata.rs
3
82.97
 -1.65% base_layer/core/src/transactions/transaction_components/encrypted_data.rs
3
0.0
 -15.79% base_layer/core/src/transactions/transaction_components/error.rs
3
84.21
 -15.79% base_layer/core/src/transactions/transaction_components/transaction_kernel_version.rs
3
85.71
 -14.29% base_layer/core/src/transactions/transaction_components/transaction_output_version.rs
3
87.5
 -2.5% base_layer/core/src/transactions/transaction_key_manager/key_manager.rs
3
88.0
 -12.0% base_layer/core/src/transactions/transaction_key_manager/storage/database/mod.rs
3
0.0
 -13.64% base_layer/wallet/src/operation_id.rs
3
0.0
 -13.04% base_layer/wallet/src/transaction_service/error.rs
3
81.82
 -0.55% comms/core/src/protocol/rpc/server/mod.rs
4
0.0
 -12.12% base_layer/common_types/src/wallet_types.rs
4
66.39
 -3.28% base_layer/core/src/transactions/transaction_key_manager/interface.rs
4
0.0
 -21.05% base_layer/wallet/src/output_manager_service/storage/output_source.rs
4
60.11
 -0.27% comms/dht/src/connectivity/mod.rs
4
0.0
 -36.36% comms/dht/src/outbound/error.rs
4
0.0
 -100.0% infrastructure/test_utils/src/comms_and_services/mod.rs
5
0.0
 -13.89% base_layer/p2p/src/domain_message.rs
6
90.48
 -2.04% base_layer/core/src/proto/transaction.rs
6
0.0
 -100.0% base_layer/wallet/src/client/http_client_factory.rs
6
73.98
 -3.06% comms/core/src/test_utils/mocks/connectivity_manager.rs
6
97.36
 -0.43% infrastructure/tari_script/src/script.rs
7
0.0
 -87.5% base_layer/wallet/src/transaction_service/utc.rs
7
56.23
 -0.7% comms/core/src/connectivity/manager.rs
8
84.42
 -1.19% base_layer/common_types/src/tari_address/mod.rs
9
96.39
 -1.12% base_layer/core/src/transactions/transaction_protocol/transaction_initializer.rs
10
0.0
 -55.56% base_layer/wallet/src/connectivity_service/handle.rs
10
0.0
 -55.56% base_layer/wallet/src/output_manager_service/storage/output_status.rs
10
34.91
 -9.43% base_layer/wallet/src/storage/sqlite_utilities/mod.rs
11
0.0
 -91.67% base_layer/wallet/src/output_manager_service/config.rs
11
0.0
 -26.19% base_layer/wallet/src/output_manager_service/input_selection.rs
11
0.0
 -47.83% base_layer/wallet/src/transaction_service/protocols/mod.rs
12
0.0
 -52.17% base_layer/wallet/src/base_node_service/handle.rs
12
0.0
 -100.0% base_layer/wallet/src/connectivity_service/initializer.rs
15
44.12
 -44.12% base_layer/common_types/src/tx_id.rs
15
57.41
 -27.78% base_layer/wallet/src/output_manager_service/storage/models.rs
16
0.0
 -5.08% clients/rust/base_node_wallet_client/src/client/http.rs
18
0.0
 -51.43% base_layer/wallet/src/transaction_service/tasks/wait_on_dial.rs
18
0.0
 -75.0% base_layer/wallet/src/util/watch.rs
19
21.43
 -67.86% base_layer/wallet/src/test_utils.rs
20
0.0
 -5.32% base_layer/wallet/src/output_manager_service/tasks/txo_validation_task.rs
20
28.18
 -6.87% base_layer/wallet/src/storage/database.rs
20
0.0
 -52.63% base_layer/wallet/src/transaction_service/config.rs
20
0.0
 -100.0% base_layer/wallet/src/utxo_scanner_service/handle.rs
21
0.0
 -37.5% base_layer/core/src/base_node/rpc/models/get_header_by_height.rs
23
0.0
 -18.7% base_layer/core/src/base_node/proto/wallet_rpc.rs
23
0.0
 -100.0% base_layer/wallet/src/transaction_service/tasks/send_transaction_cancelled.rs
23
52.81
 -8.61% comms/dht/src/outbound/requester.rs
24
0.0
 -89.29% base_layer/wallet/src/base_node_service/mod.rs
25
92.52
 -2.12% base_layer/core/src/transactions/transaction_components/payment_id.rs
25
70.39
 -12.14% base_layer/core/src/transactions/transaction_key_manager/storage/sqlite_db/mod.rs
25
77.24
 -17.24% base_layer/wallet/src/schema.rs
26
0.0
 -92.86% base_layer/core/src/transactions/transaction_protocol/proto/transaction_metadata.rs
26
63.4
 -3.03% base_layer/wallet/src/storage/sqlite_db/wallet.rs
28
0.0
 -100.0% base_layer/core/src/transactions/transaction_key_manager/initializer.rs
28
83.0
 -1.99% base_layer/core/src/transactions/transaction_protocol/sender.rs
32
52.06
 -9.41% base_layer/core/src/transactions/transaction_key_manager/wrapper.rs
34
9.52
 -32.38% base_layer/common_types/src/transaction.rs
34
0.0
 -100.0% base_layer/core/src/transactions/transaction_protocol/proto/recipient_signed_message.rs
36
64.95
 -16.82% comms/core/src/connectivity/proactive_dialer.rs
36
13.45
 -30.25% comms/core/src/protocol/rpc/server/mock.rs
43
58.41
 -12.68% base_layer/core/src/transactions/transaction_components/wallet_output.rs
47
0.0
 -18.95% base_layer/wallet/src/transaction_service/protocols/transaction_broadcast_protocol.rs
52
0.0
 -74.29% base_layer/wallet/src/storage/sqlite_db/scanned_blocks.rs
53
0.0
 -90.32% base_layer/wallet/src/output_manager_service/mod.rs
55
59.09
 -35.71% comms/dht/src/outbound/mock.rs
59
0.0
 -59.6% base_layer/wallet/src/utxo_scanner_service/uxto_scanner_service_builder.rs
65
0.0
 -85.53% base_layer/wallet/src/utxo_scanner_service/service.rs
80
46.18
 -6.37% base_layer/core/src/transactions/transaction_key_manager/inner.rs
82
0.0
 -100.0% base_layer/wallet/src/utxo_scanner_service/initializer.rs
83
23.42
 -74.77% base_layer/core/src/transactions/transaction_protocol/proto/transaction_sender.rs
91
0.0
 -62.94% base_layer/wallet/src/transaction_service/protocols/check_faux_transaction_status.rs
97
0.0
 -64.67% base_layer/wallet/src/transaction_service/tasks/send_transaction_reply.rs
101
0.0
 -60.12% base_layer/wallet/src/transaction_service/tasks/send_finalized_transaction.rs
123
0.0
 -67.58% base_layer/wallet/src/output_manager_service/recovery/standard_outputs_recoverer.rs
130
0.0
 -88.67% base_layer/wallet/src/transaction_service/mod.rs
159
0.0
 -46.49% base_layer/wallet/src/transaction_service/protocols/transaction_receive_protocol.rs
169
4.83
 -51.06% base_layer/wallet/src/transaction_service/storage/models.rs
178
0.0
 -55.63% base_layer/wallet/src/output_manager_service/storage/database/mod.rs
199
0.0
 -21.26% base_layer/wallet/src/transaction_service/handle.rs
204
0.0
 -32.28% base_layer/wallet/src/output_manager_service/handle.rs
315
9.6
 -47.23% base_layer/wallet/src/output_manager_service/storage/sqlite_db/output_sql.rs
328
0.0
 -58.89% base_layer/wallet/src/utxo_scanner_service/utxo_scanner_task.rs
343
0.0
 -61.8% base_layer/wallet/src/transaction_service/storage/database.rs
435
0.0
 -61.88% base_layer/wallet/src/transaction_service/protocols/transaction_send_protocol.rs
595
12.95
 -46.19% base_layer/wallet/src/output_manager_service/storage/sqlite_db/mod.rs
773
51.25
 -28.92% base_layer/wallet/src/transaction_service/storage/sqlite_db.rs
782
0.0
 -22.79% base_layer/wallet/src/transaction_service/service.rs
928
0.0
 -33.11% base_layer/wallet/src/output_manager_service/service.rs
Jobs
ID Job ID Ran Files Coverage
1 16200110666.1 718
58.1
 GitHub Action Run
Source Files on build 16200110666