spesmilo / electrum / 4768487903592448
63%

DEFAULT BRANCH: master
Ran
Jobs 5
Files 87
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 59.843% (+0.003%) from 59.84%
4768487903592448

push

CirrusCI

SomberNight 
follow-up prev: fix weird pyqt bug re QPushButton.clicked

When clicking the "close_button" button (labelled "Not Now"), the whole app state got bugged:
none of the existing windows (e.g. ElectrumWindow) could get focus anymore.

The signature of PushButton.clicked is:
`void QAbstractButton::clicked(bool checked = false)`
https://doc.qt.io/qt-6/qabstractbutton.html#clicked

and pyqt is probably doing some polymorphism, dynamically deciding if the qt slot wants the "checked" arg or not.

The extremely weird part is that the bug is triggered on clicking "close_button" (probably pyqt is passing "checked" to self.close)
but instead of the current commit, the following diff, touching a completely different button, would also "fix" the issue:

```
diff --git a/electrum/gui/qt/exception_window.py b/electrum/gui/qt/exception_window.py
index eceab89de6..e0162e5827 100644
--- a/electrum/gui/qt/exception_window.py
+++ b/electrum/gui/qt/exception_window.py
@@ -67,7 +67,7 @@ class Exception_Window(BaseCrashReporter, QWidget, MessageBoxMixin, Logger):

         self._report_contents_dlg = None  # type: Optional[ReportContentsDialog]
         collapse_info = QPushButton(_("Show report contents"))
-        collapse_info.clicked.connect(self.show_report_contents_dlg)
+        collapse_info.clicked.connect(lambda: self.show_report_contents_dlg())

         main_box.addWidget(collapse_info)
 ```

No idea why.

21985 of 36738 relevant lines covered (59.84%)

2.99 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
79.28
 -0.09% electrum/lnutil.py
2
60.98
 0.36% electrum/util.py
Jobs
ID Job ID Ran Files Coverage
1 4768487903592448.1 87
59.82
2 4768487903592448.2 87
59.8
3 4768487903592448.3 87
59.79
4 4768487903592448.4 87
59.79
5 4768487903592448.5 87
59.8
Source Files on build 4768487903592448