spesmilo / electrum / 5359738134724608
60%
master: 64%

LAST BUILD BRANCH: 202602_win_build
DEFAULT BRANCH: master
Ran
Jobs 5
Files 87
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 59.864% (+0.02%) from 59.84%
5359738134724608

Pull #10017

CirrusCI

f321x 
fix: qml: wizard: delete seed_type if not set

deletes the `seed_type` key from `wizard_data` in `WCWalletType` if it
is not explicitly set to prevent a stale value from a previous wizard
flow if the user goes back in the wizard and selects a different wallet
type instead of completing the wizard with the previously selected
wallet type.
This happens as the `apply()` function gets called with the
previously set radio button (e.g. 2fa) if the user goes back, if he then
selects multisig the `2fa_segwit` `seed_type` won't get cleared and
cause the exception later.
Example exception when first selecting 2fa, then going back and creating
a multisig wallet:
```
32.77 | E | gui.qml.qeapp.Exception_Hook | exception caught by crash reporter
Traceback (most recent call last):
  File "/home/vagrant/electrum/electrum/gui/qml/qewizard.py", line 40, in submit
    view = self.resolve_next(self._current.view, wdata)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/vagrant/electrum/electrum/wizard.py", line 78, in resolve_next
    view_accept(wizard_data)
  File "/home/vagrant/electrum/electrum/wizard.py", line 501, in maybe_master_pubkey
    wizard_data['multisig_master_pubkey'] = self.keystore_from_data(wizard_data['wallet_type'], wizard_data).get_master_public_key()
                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/vagrant/electrum/electrum/wizard.py", line 339, in keystore_from_data
    return keystore.from_seed(data['seed'], passphrase=seed_extension, for_multisig=for_multisig)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/vagrant/electrum/electrum/keystore.py", line 1197, in from_seed
    raise BitcoinException('Unexpected seed type {}'.format(repr(t)))
electrum.util.BitcoinException: Unexpected seed type '2fa_segwit'
```

Triggered by the following wizard stack:
```
 30.94 | D | wizard | view=create_seed... (continued)
Pull Request #10017: fix: qml: wizard: delete seed_type from wizard_data if not set explicitly

21982 of 36720 relevant lines covered (59.86%)

2.99 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
5
51.93
 0.36% electrum/fee_policy.py
19
85.21
 0.0% electrum/json_db.py
49
39.31
 0.89% electrum/lnwatcher.py
60
72.79
 0.0% electrum/txbatcher.py
185
47.17
 0.18% electrum/commands.py
259
23.56
 0.07% electrum/submarine_swaps.py
Jobs
ID Job ID Ran Files Coverage
1 5359738134724608.1 87
59.83
2 5359738134724608.2 87
59.83
3 5359738134724608.3 87
59.82
4 5359738134724608.4 87
59.83
5 5359738134724608.5 87
59.83
Source Files on build 5359738134724608