rust-bitcoin / rust-bitcoin / 16170465140

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#4649: fix: preserve embedded nulls in `CommandString` for consensus validation

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/a6f63cf61d921e6c59f0697f9b84afd744ddbf37">a6f63cf61 fix: validate ASCII and preserve embedded nulls in CommandString parsing (Erick Cestari)

Pull request description:

  Previously, `CommandString` decoding would silently normalize invalid commands containing embedded null bytes. For example, "mem\0pool" would be incorrectly decoded as "mempool", bypassing consensus validation.
  
  Found through differential fuzzing between btcd and rust-bitcoin, where rust-bitcoin was accepting messages with embedded null bytes in Command fields while btcd (and Bitcoin Core) correctly reject them.


ACKs for top commit:
  apoelstra:
    ACK a6f63cf61d921e6c59f0697f9b84afd744ddbf37; successfully ran local tests
  tcharding:
    ACK a6f63cf61d921e6c59f0697f9b84afd744ddbf37


Tree-SHA512: fccf7fc29448d5e05f5b7a4bc8bc8675a1d

Coverage Stats

12 of 12 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

21303 of 25491 relevant lines covered (83.57%)

15254.66 hits per line