• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

typeorm / typeorm / 16161935325
81%

Build:
DEFAULT BRANCH: master
Ran 09 Jul 2025 06:26AM UTC
Jobs 24
Files 329
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

09 Jul 2025 06:23AM UTC coverage: 76.44% (+0.05%) from 76.391%
16161935325

push

github

web-flow
fix: resolve array modification bug in QueryRunner drop methods (#11564)

* fix: resolve array modification bug in QueryRunner drop methods

Fix iteration bug in QueryRunner implementations where dropping multiple
database objects (columns, indices, foreign keys, unique constraints) would
skip elements due to in-place array modification during iteration.

The issue occurred when methods like dropColumns(), dropIndices(),
dropForeignKeys(), and dropUniqueConstraints() iterated over arrays while
simultaneously modifying them by removing elements. This caused a classic
"off-by-one" iteration bug where alternate elements would be skipped.

Changes:
- Update all affected QueryRunner drop methods to iterate over a shallow
  copy of the input array using [...array] spread syntax
- Add comprehensive regression tests in test/github-issues/11563/
- Test coverage includes all affected drivers: Postgres, MySQL, SQL Server,
  Oracle, CockroachDB, Spanner, SAP, and Aurora MySQL

Affected drivers:
- SpannerQueryRunner
- PostgresQueryRunner
- MysqlQueryRunner
- SqlServerQueryRunner
- OracleQueryRunner
- CockroachQueryRunner
- SapQueryRunner
- AuroraMysqlQueryRunner

Closes #11563

* fix: create multiple indices same column

* chore: functional tests instead of github issues

9322 of 12883 branches covered (72.36%)

Branch coverage included in aggregate %.

12 of 16 new or added lines in 8 files covered. (75.0%)

19015 of 24188 relevant lines covered (78.61%)

119472.11 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
1.44
0.0% src/driver/aurora-mysql/AuroraMysqlQueryRunner.ts
3
2.21
0.0% src/driver/spanner/SpannerQueryRunner.ts
Jobs
ID Job ID Ran Files Coverage
1 mongodb-node:18 - 16161935325.1 09 Jul 2025 06:26AM UTC 329
17.09
GitHub Action Run
2 better-sqlite3-node:18 - 16161935325.2 09 Jul 2025 06:26AM UTC 329
39.18
GitHub Action Run
3 sap-node:20 - 16161935325.3 09 Jul 2025 06:36AM UTC 329
40.0
GitHub Action Run
4 sqljs-node:20 - 16161935325.4 09 Jul 2025 06:27AM UTC 329
38.58
GitHub Action Run
5 sqlite-node:20 - 16161935325.5 09 Jul 2025 06:28AM UTC 329
39.6
GitHub Action Run
6 sqljs-node:20-windows - 16161935325.6 09 Jul 2025 06:27AM UTC 329
38.59
GitHub Action Run
7 postgres:14-3.5-node:20 - 16161935325.7 09 Jul 2025 06:27AM UTC 329
44.97
GitHub Action Run
8 sap-node:18 - 16161935325.8 09 Jul 2025 06:34AM UTC 329
40.0
GitHub Action Run
9 mssql-node:20 - 16161935325.9 09 Jul 2025 06:29AM UTC 329
42.76
GitHub Action Run
10 sqlite-node:18 - 16161935325.10 09 Jul 2025 06:26AM UTC 329
39.6
GitHub Action Run
11 better-sqlite3-node:20-windows - 16161935325.11 09 Jul 2025 06:27AM UTC 329
39.18
GitHub Action Run
12 postgres:14-3.5-node:18 - 16161935325.12 09 Jul 2025 06:27AM UTC 329
44.98
GitHub Action Run
13 mysql+mariadb-node:20 - 16161935325.13 09 Jul 2025 06:28AM UTC 329
42.09
GitHub Action Run
14 crdb-node:20 - 16161935325.14 09 Jul 2025 06:47AM UTC 329
41.23
GitHub Action Run
15 postgres:17-3.5-node:20 - 16161935325.15 09 Jul 2025 06:27AM UTC 329
44.97
GitHub Action Run
16 sqljs-node:18 - 16161935325.16 09 Jul 2025 06:26AM UTC 329
38.58
GitHub Action Run
17 oracle-node:18 - 16161935325.17 09 Jul 2025 06:34AM UTC 329
40.49
GitHub Action Run
18 mongodb-node:20 - 16161935325.18 09 Jul 2025 06:26AM UTC 329
17.09
GitHub Action Run
19 postgres:17-3.5-node:18 - 16161935325.19 09 Jul 2025 06:27AM UTC 329
44.97
GitHub Action Run
20 mysql+mariadb-node:18 - 16161935325.20 09 Jul 2025 06:28AM UTC 329
42.1
GitHub Action Run
21 sqlite-node:20-windows - 16161935325.21 09 Jul 2025 06:28AM UTC 329
39.61
GitHub Action Run
22 mssql-node:18 - 16161935325.22 09 Jul 2025 06:29AM UTC 329
42.75
GitHub Action Run
23 better-sqlite3-node:20 - 16161935325.23 09 Jul 2025 06:27AM UTC 329
39.18
GitHub Action Run
24 oracle-node:20 - 16161935325.24 09 Jul 2025 06:36AM UTC 329
40.49
GitHub Action Run
Source Files on build 16161935325
  • Tree
  • List 329
  • Changed 11
  • Source Changed 8
  • Coverage Changed 9
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • Github Actions Build #16161935325
  • f351757a on github
  • Prev Build on master (#16152876531)
  • Next Build on master (#16404418107)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc