babelfish-for-postgresql / babelfish_extensions / 16152366920

76%

BABEL_5_X_DEV: 77%

Build Type

push

github

Committed by web-flow

Commit Message

Fix insert execute output parameters and nested levels issues (#3937)

Description

This commit addresses issues with INSERT ... EXECUTE statements in stored procedures, specifically fixing output parameter handling and preventing unsupported nested execution scenarios.

Issues

Output Parameter Handling: INSERT ... EXECUTE statements with output parameters were not properly capturing and assigning return values from executed stored procedures
Nested INSERT ... EXECUTE statements: Need to block nested INSERT ... EXECUTE statements

Changes

Added a new function setup_procedure_output_target_for_insert_exec() to prepares output parameter targets for INSERT ... EXECUTE statements by analyzing the called procedure's signature and setting up appropriate data structures
Maintained a global variable execute_call_insert_exec_retval to pass return values between execution contexts when procedures are called via INSERT ... EXECUTE
Added stack traversal logic to detect nested INSERT ... EXECUTE calls and provide error message

Task: BABEL-5306, BABEL-2151
Signed-off-by: RUI LUO <rluo@amazon.com>

Run Details

55 of 67 new or added lines in 1 file covered. (82.09%)

2 existing lines in 1 file now uncovered.

49297 of 65258 relevant lines covered (75.54%)

316281.5 hits per line