Qiskit / qiskit / 16146286725

88%

main: 88%

Build Type

push

github

Committed by web-flow

Commit Message

Move classical variables and stretches to CircuitData (#14421)

* Add groundwork for vars storage in CircuitData

Adding basic support for vars and identifier storage and access, using
the same approach implemented in DAGCircuit with `ObjectRegsitry` and
various var-types structs. In addition updating `QuantumCircuit` to use
`CircuitData` for input vars.

* Handle captured and declared vars in QuantumCircuit

* Move stretch to CircuitData

* Handle vars & stretches in Rust in dag_to_circuit

* Add pickle/unpickle support + minor misc. stuff

* Use CircuitData'a vars/stretches natively in QuantumCircuitData

* Clone interners in CircuitData::copy_empty_like

* Add scoping rule checks to CircuitData

This commit adds checks to CircuitData::add_var and CircuitData::add_stretch
functions to enforce variable scoping rules. It also includes minor refactoring
and miscellaneous cleanups.

* Update BlueprintCircuit & twirling and cleanup

* Add unit tests. Some refactoring and cleanups

* Minor touches

* Lint and comment

* Fix metadata handling following changes in high_level_synthesis.rs

Since this PR no longer uses a custom function to convert a circuit to DAG in
run_high_level_synthesis, we should use DAGCircuit::from_circuit
with QuantumCircuitData initialized with both name and metadata from
the original DAG.

* Address some of Jake's review comments

Relax equality checking to allow variable order independence (modulo the declared stretches).
Minor refactoring.

* Use the `VarsMode` enum in Python's `copy_empty_like`

Following PR #14557, this commit switches to using the `VarsMode` enum
in the Pyo3 function `CircuitData::copy_empty_like`.
Additionaly, since the enum is now used both by `CircuitData` and `DAGCircuit`
and in various placed, it has been moved to the crate level.

* Update crates/circuit/src/circuit_data.rs

Co-authored-by: Raynel Sanchez <87539502+raynelfss@users.noreply.github.com>

* Update qiskit/circuit/quantumcircuit.py

Co-authore... (continued)

Run Details

570 of 604 new or added lines in 11 files covered. (94.37%)

25 existing lines in 7 files now uncovered.

81609 of 92988 relevant lines covered (87.76%)

547445.01 hits per line