babelfish-for-postgresql / babelfish_extensions / 16122560072

77%

push

github

handle_dropdb() check has been moved to upper side of superuser check to prevent remove  Babelfish exclusive database directly by superuser. (#3888)

Previously, Babelfish-protected databases could be dropped by superusers using generic SQL clients (e.g., psql) without triggering the intended safeguards. This occurred because the logic to intercept and handle DROP DATABASE for Babelfish was placed after a superuser() check in tdsutils_ProcessUtility(). As a result, the handler handle_dropdb() was never reached for superusers.

This merge request reorders the logic so that the handle_dropdb() function is called before the superuser() check. This ensures that Babelfish databases are always validated and protected against direct deletion unless sys.remove_babelfish() has been explicitly called — even for superusers. This change enforces a consistent and safe behavior across all client types.

Issues Resolved
[#3875] Babelfish database can be dropped via SQL clients without proper cleanup, leading to reinitialization failure

Co-authored-by: Rohat Karataş <rohat.karatas@huawei-partners.com>

2 of 2 new or added lines in 1 file covered. (100.0%)

49562 of 65272 relevant lines covered (75.93%)

314976.21 hits per line