Qiskit / qiskit / 16113285112

88%

main: 88%

Build Type

push

github

Committed by web-flow

Commit Message

Restore correct max_trials behaviour for VF2Layout pass (#14667) (#14692)

* Restore correct max_trials behaviour for VF2Layout pass

The VF2Layout pass is documented as setting a trial limit equivalent to
the being based on the number of edges of the interaction or connectivity
graph. Additionally it supports being a negative value to run unbounded.
However, when vf2 layout was ported to rust in #14056 this behavior was
not preserved. It was not able to handle negative values and also a
value of None was treated as unbounded. This commit corrects these
oversights so the argument to the pass is handled correctly as
documented.

* Improve tests

The previous version of the tests in this module didn't set the seed
correctly, so the rust component was not run. Similarly, the tests
didn't cover the strict direction path. This commit corrects both
oversights so the tests added in this PR cover the fix.

(cherry picked from commit 6e4d83cf2)

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

Run Details

24 of 25 new or added lines in 1 file covered. (96.0%)

6 existing lines in 3 files now uncovered.

80108 of 91315 relevant lines covered (87.73%)

511119.66 hits per line