opengovsg / FormSG / 16111031269

72%

push

github

feat: mobile btn v3 (#8493)

* Add OTPVerificationTextStack to EditMobile FE

* add OTPVerificationTextCheck im8 texts

* update OTPVerificationTextStack with im8 texts & include contact support link

* OTPVerificationTextStack styling and spacing

* create MobileOTPModalProps

* replace OTP verification messages with standardized components

* replace modal with original smsCountsMdal

* show modal on enabling OTP verification toggle, refactored some texts

* add useSmsQuota to queries

* getSmsQuota to AdminViewForService

* include routes and handler to obtain sms counts & quota on BE

* include config, service and model for sms, updated to be used in control handler

* add sms types

* update query to query for sms counts by formId not by userId

* update FE to query for counts in the db

* add log to sms table for each successful otp message sent

* resolved FE message copy issues

* resolve FE api call to find sms counts and display

* remove local dev mail testing and logging

* added checkFormSmsLimitAndDeactivateForm to formService

* add util function and implement check if form has verifiable form fields

* implement sms threshold check to deactivate form in public form controller

* include formdeactivated mail component

* add formdeactivatednotificationhtml data type

* create sendFormDeactivatedNotification to MailService

* implement formdeactivatednotification sending when sms threshold is reached and form is turned off

* resolve sending formdeactivatednotification mail err to async

* resolved BE lint and error handling for mail sending

* add collaborators to the deactivated email

* void mail service result to return ResultAsync properly

* make logSendSms to return databaseerror

* fix bug for count query to query per form & not entire collection

* add noSmsLimit flag to surpass threshold limit

* resolved checkFormSmsLimitAndDeactivateForm to always return resultasync or asyncerr

* updated form.server.model.spec.ts with noSmsL... (continued)

2926 of 4941 branches covered (59.22%)

Branch coverage included in aggregate %.

92 of 145 new or added lines in 13 files covered. (63.45%)

10560 of 13806 relevant lines covered (76.49%)

48.53 hits per line