goto / compass / 16110198089
81%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 87
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 80.528%. First build
16110198089

push

github

web-flow 
feat: soft deletion [all] (#96)

* feat: soft delete by ID

* fix: delete asset service logic

* fix: soft delete by ID succeeded

* refactor: resolved lint issue

* feat: get API handle is deleted

* refactor: resolve lint issues

* feat: return soft deletion flag

* feat: search API handle soft deletion

* feat: soft delete by query

* refactor: generate mock and solve lint issues

* fix: soft delete by ID succeeded

* feat: soft deletion by query

* refactor: resolve lint issues

* fix: trigger condition and unit test

* feat: handle insert auto version, and create unit test

* refactor: change params and make new version asset in elasticsearch based on DB

* revert: restore unaffected code

* feat: return soft deletion flag

* feat: resolve merge conflict

* feat: update golangci-lint

* feat: update github workflows

* refactor: argument name

* refactor: extract the query value conversion logic

* fix: golangci lint

* test: add case restore asset

* fix: is_deleted column should be updated as well in assets_versions table

* refactor: resolve lint issues

* feat: handle soft deletion on lineage

* feat: resolve merge conflict

* refactor: DB and elasticsearch soft deletion

* feat: handle lineage soft deletion

* feat: resolve merge

* refactor: get asset query

* feat: set default search is deleted false and return the correct value

* feat: set default group assets is deleted false and unit test

* fix: delete by query, and group assets can accept is_deleted

---------

Co-authored-by: Muhammad Luthfi Fahlevi <muhammad.fahlevi@gojek.com>

584 of 708 new or added lines in 13 files covered. (82.49%)

7622 of 9465 relevant lines covered (80.53%)

28.96 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
4
94.74
 -5.26% core/asset/filter.go
6
85.89
 -14.11% internal/store/elasticsearch/discovery_search_repository.go
7
69.78
 -30.22% pkg/queryexpr/es_expr.go
8
72.35
 -27.65% internal/workermanager/discovery_worker.go
11
88.5
 -11.5% core/asset/service.go
14
82.93
 -17.07% internal/store/postgres/lineage_repository.go
24
62.81
 -37.19% internal/store/elasticsearch/discovery_repository.go
50
77.83
 -22.17% internal/store/postgres/asset_repository.go
Jobs
ID Job ID Ran Files Coverage
1 16110198089.1 87
80.53
 GitHub Action Run
Source Files on build 16110198089