MITLibraries / dspace-submission-composer / 16055691110

95%

main: 96%

Build Type

push

github

Committed by web-flow

Commit Message

IN-1317 Update submit CLI command to use DynamoDB (#181)

* IN-1317 Update submit CLI command to use DynamoDB

Why these changes are being introduced:
* The submit CLI command and the Workflow methods it calls need to be updated to use DynamoDB

How this addresses that need:
* Remove SUBMIT_MAX_RETRIES_REACHED from ItemSubmissionStatus and rename INGEST_MAX_RETRIES_REACHED > MAX_RETRIES_REACHED
* Update Workflow.submit_items to accept a run_date param
* Add retry_threshold property to Workflow class
* Add allow_submission and write_submit_results_to_dynamodb to Workflow class and corresponding unit tests

Side effects of this change:
* None

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/IN-1317

* Updates based on discussion in PR # 181

* Refactor run_date as a Workflow instance attribute and remove run_date args from methods
* Add RETRY_THRESHOLD as Config property sourced from env var and update README.md
* Refactor submit_items method to directly update DynamoDB
* Add skipped count to submission_summary
* Refactor allow_submission method to accept already created ItemSubmissionDB instance and to use match/case pattern
* Remove write_submit_results_to_dynamodb method and corresponding unit test
* Add new unit tests and update existing unit tests to account for updated functionality

* More updates based on discussion in PR #181

* Create ITEM_SUBMISSION_LOG_STR and replace method logging templates
* Update description of RETRY_THRESHOLD in README.md
* Update unit test names for consistency and streamline allow_submission unit tests

Run Details

42 of 49 new or added lines in 4 files covered. (85.71%)

2 existing lines in 1 file now uncovered.

875 of 917 relevant lines covered (95.42%)

0.95 hits per line