kubevirt / containerized-data-importer / #5434

49%

Build Type

push

travis-ci

Committed by web-flow

Commit Message

Bugfix: Fix math in overhead size calculations  (#3779)

* Fix GetUsableSpace calculation

GetUsableSpace had wrong assumptions about undoing overhead calculations. This commit fixes the math and updates the appropriate unit tests.

Signed-off-by: Alvaro Romero <alromero@redhat.com>

* Fix GetRequiredSpace calculations

GetRequiredSpace uses wrong math to calculate overhead expansion, which usually causes inflated space to be significantly larger than it should.

This commit fixes this calculation and removes the redundant CalculateOverheadSpace.

Signed-off-by: Alvaro Romero <alromero@redhat.com>

* Fix functional tests that assume bad fs overhead inflation

Signed-off-by: Alvaro Romero <alromero@redhat.com>

* Increase image size in upload test to avoid overhead inflation issue

There's a known issue where the default overhead inflation is insufficient to account for the fs overhead in smaller images.

This commit increases the image size in a test so the overhead inflation is enough for the upload to succeed.

Signed-off-by: Alvaro Romero <alromero@redhat.com>

---------

Signed-off-by: Alvaro Romero <alromero@redhat.com>

Run Details

20 of 21 new or added lines in 3 files covered. (95.24%)

2 existing lines in 1 file now uncovered.

16982 of 28577 relevant lines covered (59.43%)

0.66 hits per line