bitcoindevkit / bdk / 16052960758

79%

push

github

Merge bitcoindevkit/bdk#1971: esplora: `chain_update` errors if no point of connection

<a class=hub.com/bitcoindevkit/bdk/commit/568a36642c43d74132339a4e42dd41c545a764e1">568a36642<a href="https://github.com/bitcoindevkit/bdk/commit/c496cde270c615b3a4b997d8407b9f9aac2d7dcb"> refactor(esplora): in debug build assert that `latest_blocks` is not empty (valued mammal)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/dd394cb31869df89c5e5b3bbbf88e26763348878">dd394cb31</a> fix(esplora): `chain_update` errors if no point of connection (valued mammal)

Pull request description:

  ### Description

  Before, the `chain_update` function might have panicked if the local checkpoint was not on the same network as the remote server. Now if we have iterated all of the blocks of the local CP and do not find a point of agreement, then we return early with a `esplora_client::Error::HeaderHashNotFound`.

  cc bitcoindevkit/bdk_wallet#30

  ### Notes to the reviewers

  ### Changelog notice

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo +nightly fmt` and `cargo clippy` before committing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [x] I've added tests to reproduce the issue which are now passing
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  ValuedMammal:
    ACK 568a36642c43d74132339a4e42dd41c545a764e1

Tree-SHA512: 8dceaf24f19962af04020e38b2af828360a

82 of 90 new or added lines in 2 files covered. (91.11%)

5325 of 6480 relevant lines covered (82.18%)

33124.26 hits per line