bitcoindevkit / bdk_wallet / 16051833597

85%

push

github

Merge bitcoindevkit/bdk_wallet#258: feat: Add `exclude_unconfirmed` and `exclude_below_confirmations`

<a class=hub.com/bitcoindevkit/bdk_wallet/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk_wallet/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk_wallet/commit/5a6542266c7603b0e7bdf5807e6d5d03c8ce1b15">5a6542266 feat: Add `exclude_unconfirmed` and `exclude_below_confirmations` (志宇)

Pull request description:

  Fixes #143

  ### Description

  These are convenience methods on `TxBuilder` that can be used to filter out outpoints which do not meet a given confirmation threshold.

  Previously, I advocated a feature freeze on `TxBuilder`, but I believe we can make an exception for these helper methods, as they do not broaden the `TxBuilder` interface’s error surface. Going forward, all other development should be directed to the [`bdk-tx`](https://github.com/bitcoindevkit/bdk-tx) repository and crate.

  cc. @tnull

  ### Changelog notice

  ```md
  Added:
  - `TxBuilder::exclude_unconfirmed`
  - `TxBuilder::exclude_below_confirmations`
  ```

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo +nightly fmt` and `cargo clippy` before committing

  #### New Features:

  * [x] I've added tests for the new feature
  * [x] I've added docs for the new feature

ACKs for top commit:
  ValuedMammal:
    ACK 5a6542266c7603b0e7bdf5807e6d5d03c8ce1b15
  oleonardolima:
    utACK 5a6542266c7603b0e7bdf5807e6d5d03c8ce1b15
  notmandatory:
    ACK 5a6542266c7603b0e7bdf5807e6d5d03c8ce1b15

Tree-SHA512: f458ce62cb9ee8df14391ba3cf9dce7ef67

83 of 86 new or added lines in 1 file covered. (96.51%)

6577 of 7762 relevant lines covered (84.73%)

3411.23 hits per line