kubevirt / hyperconverged-cluster-operator / 16018029710
76%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 82
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 75.43% (-0.2%) from 75.599%
16018029710

push

github

web-flow 
Monitor the cluster architectures (#3594)

* monitor and cache the cluster node architectures

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* API changes

1. add the new `nodeInfo` field to the HyperConverged's status
2. add the `conditions` field to the DICT status type
3. add the `originalSupportedArchitectures` field to the DICT status
   type.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* Set the new status fields when the nodeinfo is changed

Move the setting of the HA status field to the HC controller.

The nodes controller only triggers the reconciliation of the HC, but
not changes the HC CR status.

Trigger the HC reconciliation will also promise the right setting of the
DataImportCronTemplates in SSP, in a following commit.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* validate the nodePlace Affinity field

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* collect node information on boot time

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* update SSP validation

Use the HyperConverged status new fields, to get the node architectures
for the SSP validation.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* Filter unsupported architectures from DICTs

If there are no supported architectures for a specific DICT, it will not
added to the SSP CR.

The DICTs in the HyperConverged status will have the
`ssp.kubevirt.io/dict.architectures` annotation only with the
architectures that are both suppported by the image, and by the
cluster.

But if there are no supported architectures for a specific DICT, in
addition to not be copied to the SSP CR, its DICT object in the HC
status will have the the new `Deployed` condition in its status,
with status of `False` and reason of `"UnsupportedArchitectures"`.

Also, each DICT object in the HyperConverged status, will have the
new status.originalSupportedArchitectures, with the original values
from the annotation (for debug,... (continued)

246 of 351 new or added lines in 8 files covered. (70.09%)

7 existing lines in 4 files now uncovered.

6585 of 8730 relevant lines covered (75.43%)

1.5 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
3
91.3
 17.97% pkg/internal/nodeinfo/nodeinfo.go
4
94.81
 -0.58% controllers/operands/ssp.go
6
90.69
 -0.71% pkg/webhooks/validator/validator.go
9
89.89
 -10.11% controllers/reqresolver/reqresolver.go
18
49.32
 15.51% controllers/nodes/nodes_controller.go
26
80.18
 -1.88% controllers/hyperconverged/hyperconverged_controller.go
39
0.0
 controllers/nodes/predicates.go

Uncovered Existing Lines

Lines Coverage ∆ File
1
80.18
 -1.88% controllers/hyperconverged/hyperconverged_controller.go
1
81.32
 -1.1% controllers/operands/quickStart.go
2
49.32
 15.51% controllers/nodes/nodes_controller.go
3
95.86
 -1.78% controllers/operands/operandHandler.go
Jobs
ID Job ID Ran Files Coverage
1 Unit - 16018029710.1 82
75.43
 GitHub Action Run
Source Files on build 16018029710