bitcoindevkit / bdk_wallet / 16006598740

85%

Build Type

push

github

Committed by oleonardolima

Commit Message

Merge bitcoindevkit/bdk_wallet#265: Prefer Utxo::Local over Utxo::Foreign in OldestFirstCoinSelection

<a class=hub.com/bitcoindevkit/bdk_wallet/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk_wallet/commit/345cc6ea553a2db74742fa9e673985004d852fb9">345cc6ea5 fix(coin_selection): prefer Utxo::Local over Utxo::Foreign in OldestFirstCoinSelection (nymius)

Pull request description:

  ### Description

  The comments in the `OldestFirstCoinSelection` implementation stated the following:
  > // For utxo that doesn't exist in DB, they will have lowest priority to be selected

  But this was not honored in the code.

  This PR enforces this and ensures the expected behaviour through the two following new tests:
  - `test_oldest_first_coin_selection_uses_all_optional_with_foreign_utxo_locals_sorted_first`
  - `test_oldest_first_coin_selection_uses_only_all_optional_local_utxos_not_a_single_foreign`

  Fixes #264

  ### Changelog notice

  No public APIs are changed by these commits.

  ### Checklists

  > [!IMPORTANT]
  > This pull request **DOES NOT** break the existing API
  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo +nightly fmt` and `cargo clippy` before committing
  * [x] I've added tests for the new code
  * [x] I've expanded docs addressing new code
  * [x] I've added tests to reproduce the issue which are now passing
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  ValuedMammal:
    ACK 345cc6ea553a2db74742fa9e673985004d852fb9
  oleonardolima:
    ACK 345cc6ea553a2db74742fa9e673985004d852fb9

Tree-SHA512: 8a538e0765a5bb13c3405a9e35f80af866b

Run Details

68 of 68 new or added lines in 1 file covered. (100.0%)

14 existing lines in 5 files now uncovered.

6525 of 7707 relevant lines covered (84.66%)

3431.2 hits per line