tarantool / luajit / 16004999640

93%

tarantool/master: 93%

Build Type

push

github

Committed by Buristan

Commit Message

Fix error generation in load*.

Reported by Sergey Kaplun.

(cherry picked from commit e76bb50d4)

The chunkname pointer to the "@filename" is put on the Lua stack
before the `lua_loadx()` and is removed right before the next
`lua_pushfstring()` in case of the error. If the GC takes the step
right at this moment inside `lua_pushfstring()` the string may be
collected, and the next read from this `chunkname + 1` is from the
deallocated memory.

This patch fixes this by using the source string (or the constant one)
instead.

Sergey Kaplun:
* added the description and the test for the problem

Part of tarantool/tarantool#11278

Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org>
Signed-off-by: Sergey Kaplun <skaplun@tarantool.org>
(cherry picked from commit 046e9b3a0)

Run Details

5710 of 6047 branches covered (94.43%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

25 existing lines in 6 files now uncovered.

21781 of 23509 relevant lines covered (92.65%)

3980436.26 hits per line