tarantool / tarantool / 15999441808
88%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 511
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 87.54% (-0.02%) from 87.56%
15999441808

push

github

sergepetrenko 
box: introduce "waiting_for_own_rows" mode

Before this, there was a special mechanism that determined whether an
instance had received all of its rows that it lost during a restart -
to do this, it simply checked that it was currently in the orphan status.
This approach can be called a heuristic, which, unfortunately, does not
work in specific cases.

Instead, it would be much more "correct" for an instance to look at the
maximum lsn among the replicas in the replica set for the component
corresponding to that instance. This will work in all the same cases
where the previous approach worked, but in many more. But it is worth
noting that this approach does not guarantee that one day an instance
will not unexpectedly receive some of its transactions from the past
that have already been overwritten by a new transaction.

Now if an instance realizes that it hasn't received all of its
transactions yet, it goes into "waiting_for_own_rows" mode. This mode
is another ro-reason similar to "orphan" mode. While the instance is in
"waiting_for_own_rows" mode it is read-only.

Closes #10592

@TarantoolBot document
Title: new `box.info.status` - "waiting_for_own_rows"
Product: Tarantool

Root document: https://www.tarantool.io/ru/doc/latest/reference/reference_lua/box_info/status/

The `waiting_for_own_rows` status can be relevant if a node that was once
a master crashed and lost some of its xlogs for some reason (e.g. manually
deleted by the user). In this case after rebooting, `box.info.status` will
be equal to `waiting_for_own_rows`, which means that the instance knows
that some of its transactions were lost from its xlogs and it is waiting
for them to be received via replication. While instance status is
`waiting_for_own_rows` it remains read-only.

70641 of 124437 branches covered (56.77%)

55 of 57 new or added lines in 3 files covered. (96.49%)

221 existing lines in 19 files now uncovered.

103843 of 118623 relevant lines covered (87.54%)

2772530.01 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
2
90.91
 -0.56% src/box/box.cc

Uncovered Existing Lines

Lines Coverage ∆ File
1
90.7
 -0.07% src/box/applier.cc
1
88.2
 -0.62% src/box/engine.c
1
95.31
 -1.56% src/box/engine.h
1
90.14
 -0.08% src/box/vy_log.c
1
96.38
 -0.72% src/box/vy_point_lookup.c
1
90.38
 -1.92% src/lib/core/trigger.cc
1
97.46
 0.3% src/lib/msgpuck/msgpuck.h
2
90.98
 -0.18% src/box/memtx_engine.cc
2
92.49
 -0.04% src/box/vinyl.c
2
94.78
 -0.42% src/box/vy_read_iterator.c
2
85.61
 -0.72% src/lib/core/coio.c
2
85.13
 -0.32% src/lib/core/say.c
3
93.62
 -1.6% src/box/vy_range.c
3
87.81
 -0.2% src/box/vy_run.c
3
22.64
 -0.04% src/lib/uri/uri_parser.c
5
95.83
 0.18% src/box/replication.cc
5
97.72
 -0.81% src/lib/salad/rtree.c
9
88.14
 -7.63% src/box/vy_regulator.c
176
90.91
 -0.56% src/box/box.cc
Jobs
ID Job ID Ran Files Coverage
1 15999441808.1 511
87.54
 GitHub Action Run
Source Files on build 15999441808