tari-project / tari / 15983436312
62%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 697
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 71.686% (-0.2%) from 71.908%
15983436312

push

github

web-flow 
feat: auto zero value coinbase reward calculation (#7259)

Description
---
This adds way to auto use correct (max) coinbase value in case you pass
single coinbase with zero value.

Motivation and Context
---
This is hard to guess correct coinbase value to pass its check in
GetNewBlockWithCoinbases and GetNewBlockTemplateWithCoinbases GRPC
methods.

How Has This Been Tested?
---
Tested as part of RandomX-T pool implementation. Will add new
integration tests to this PR but I was not able to run them locally
since I can't find seed node setup environment.

What process can a PR reviewer use to test or verify this change?
---
Run new integration scenario: Verify gprc can create block with zero
value coinbase

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Bug Fixes**
- Improved handling of blocks with a single zero-value coinbase,
ensuring it is assigned a minimal or full block reward as appropriate.
- **Tests**
- Added integration tests to verify processing and submission of blocks
containing a single zero-value coinbase output.
- Introduced a test scenario validating block creation with a zero-value
coinbase via the gRPC interface.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: stringhandler <stringhandler@gmail.com>
Co-authored-by: SW van Heerden <swvheerden@gmail.com>

82866 of 115596 relevant lines covered (71.69%)

239780.82 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
50.65
 -0.16% base_layer/core/src/base_node/sync/header_sync/synchronizer.rs
1
34.7
 -0.24% base_layer/core/src/base_node/sync/rpc/service.rs
1
98.2
 0.17% base_layer/core/src/consensus/consensus_manager.rs
1
90.55
 -0.25% comms/core/src/multiplexing/yamux.rs
3
74.59
 -0.24% base_layer/wallet/src/output_manager_service/storage/sqlite_db/mod.rs
3
83.54
 -0.11% base_layer/wallet/src/transaction_service/storage/sqlite_db.rs
3
81.77
 -1.66% comms/core/src/protocol/rpc/status.rs
4
83.01
 -1.94% base_layer/core/src/transactions/transaction_key_manager/storage/sqlite_db/mod.rs
7
64.26
 -0.94% comms/dht/src/connectivity/mod.rs
8
41.67
 -16.67% base_layer/core/src/base_node/sync/hooks.rs
10
16.67
 -55.56% base_layer/core/src/base_node/sync/ban.rs
10
0.0
 -23.81% base_layer/core/src/base_node/sync/block_sync/error.rs
10
63.32
 -0.36% base_layer/core/src/chain_storage/blockchain_database.rs
10
58.56
 -0.35% comms/core/src/connectivity/manager.rs
14
51.32
 -4.11% base_layer/core/src/base_node/state_machine_service/states/listening.rs
15
56.74
 -0.46% base_layer/wallet/src/transaction_service/service.rs
62
0.0
 -63.27% base_layer/core/src/base_node/state_machine_service/states/block_sync.rs
123
0.0
 -38.08% base_layer/core/src/base_node/sync/block_sync/synchronizer.rs
Jobs
ID Job ID Ran Files Coverage
1 15983436312.1 697
71.69
 GitHub Action Run
Source Files on build 15983436312