andreasjansson / greger.el / 147

94%

Build Type

push

github

Committed by web-flow

Commit Message

More cleanup and increase coverage (#71)

* Refactor greger-tools--extract-function-args to use cl-loop

Replace dolist with cl-loop to fix invalid cl-return usage. The cl-return
statements were invalid outside of cl-loop context. Now using cl-loop with
'until' clause to stop at &rest parameters and 'unless' to skip &optional
markers, eliminating the need for cl-return entirely.

* Make greger-tools--extract-function-args more idiomatic cl-loop

Replace let-bound variables with cl-loop's 'for' clauses and replace cond
with cl-loop's 'if'/'else' constructs. This is much more idiomatic to the
cl-loop style and eliminates nested let and cond expressions.

* Remove unnecessary nreverse in greger-tools--extract-function-args

cl-loop's collect clause builds the list in iteration order, so nreverse
is no longer needed. The original code needed it because push builds lists
in reverse order, but collect preserves the natural iteration order.

* Fix cl-loop variable binding issue with &optional marker

The unless clause was skipping iterations entirely including variable
bindings. Changed to use when clause to only process real parameters
and skip &optional/&rest markers cleanly.

* Add debug script to test cl-loop function argument extraction

* Fix cl-loop to properly filter out &optional markers

The when clause wasn't preventing variable binding for &optional markers.
Reverted to simple approach with unless and collect clauses only.

* Remove debug script after successful fix

* Add tests for greger with-context, greger-set-model, and greger-debug-request

Added comprehensive tests for:
- greger with-context functionality: `(greger t)` - tests buffer creation,
  window splitting, and context insertion
- greger-set-model: tests model selection and variable setting
- greger-debug-request: tests request data debugging and JSON file creation

* Enhance greger-debug-request to open the created JSON file

Modified greger-debug-request to automatically open the c... (continued)

Run Details

14 of 15 new or added lines in 2 files covered. (93.33%)

1 existing line in 1 file now uncovered.

1956 of 2091 relevant lines covered (93.54%)

19.69 hits per line