xapi-project / xen-api / 15927418016
78%
master: 80%

LAST BUILD BRANCH: gh-readonly-queue/master/pr-6642-1d836937c3e88e690487bebebe8757038e77138e
DEFAULT BRANCH: master
Ran
Jobs 1
Files 33
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 77.719%. Remained the same
15927418016

push

github

web-flow 
Move collection of memory metrics from xcp-rrdd to rrdp-squeezed (#6561)

The former should not collect any metrics, and instead only consolidate
them, while the latter was already collecting memory metrics using
xenctrl and xenstore, but only 2 of them.

Xapi had to be modified to be able to collect the metrics from the new
source, since the file where they reside has changed.

The memory_target metric was also associated with xenopsd and an RPC
call. These are no longer needed and code has been deleted.

The only functional change is that now memory_target is not reported
when it's not available. The new behaviour makes it work the same as
other guest-agent-reported metrics. Previously it was reported as 0
instead, which was incorrect. Since the other metrics are reported in
the same way, clients already know how to cope with this behaviour.

Tests done have compared an unpatched host with a patched one:
- Upgrade using yum update:
  * no changes apparent in xencenter, both on host and vm tabs
* none of the metrics disappeared, and they have the same metadata.
Checked with rrd2csv, xe vm-data-sources-list and xe
host-data-sources-list
* memory-target now is reported as N/A in rrd2csv, it was previously
reported as 0 (expected change)
  * Host metrics are still shown in the database with correct numbers
```
# xe host-param-list uuid=5efc236c-f137-4df7-9902-ba8fbf9a2ac2 | grep mem
                       memory-overhead ( RO): 639635456
                          memory-total ( RO): 33849733120
                           memory-free ( RO): 26117525504
                  memory-free-computed ( RO): 26077683712
```
- New host installation:
  * xencenter performance tabs look fine
* memory-target is now missing (expected change, because this metric was
never collected)
* Host metrics are shown and total memory matches update case (same host
was used, with the VMs using less memory)
```
# xe host-param-list uuid=b9c0e6d5-c362-469f-8147-38184125e9be | grep me... (continued)

3359 of 4322 relevant lines covered (77.72%)

0.78 hits per line

Jobs
ID Job ID Ran Files Coverage
1 python3.11 - 15927418016.1 33
77.72
 GitHub Action Run
Source Files on build 15927418016