agama-project / agama / 15924451705

push

github

feat: warn the user when using a weak password (#2513)

## Problem

Agama's web user interface does not warn the user when using a weak
password (e.g., "12", "12345678", "secret", etc.).

- [bsc#1237480](https://bugzilla.suse.com/show_bug.cgi?id=1237480)

## Solution

Agama will not prevent the user about doing that. After all, the
unattended mode writes just the password included in the profile.
However, it will warn the user in those cases.

This feature is based on `libpwquality`, which checks several aspects
related to the password strength. In the future, we might introduce a
visual indicator of the strenght or try to display all the rules, but
this one looks like a good enough first step.

## Testing

- [x] Added a new unit test
- [x] Tested manually

## Screenshots

*If the fix affects the UI attach some screenshots here.*

1874 of 3427 branches covered (54.68%)

Branch coverage included in aggregate %.

26 of 29 new or added lines in 7 files covered. (89.66%)

23692 of 36317 relevant lines covered (65.24%)

47.1 hits per line