dcdpr / jp / 15921540555

58%

Build Type

push

github

Committed by web-flow

Commit Message

fix(llm, llamacpp): Loosen model ID validation (#163)

The validation logic for model IDs was too strict to support model names
often used in the Llama.cpp ecosystem. For example, a model ID like
`llamacpp/bartowski_Qwen2.5-7B-Instruct-GGUF_Qwen2.5-7B-Instruct-Q4_K_M.gguf`
was previously rejected, but can now be used with JP.

Additionally, the model listing implementation was inadvertently left
out of the implementation of the Llamacpp provider. This commit fixes
that oversight.

It should be noted that it is not possible (unless the llama.cpp server
is run with the `--alias` flag[1]) to get the proper model name from the
API (instead, it points to the model file on disk), so in reality this
implementation isn't particularly useful, but at least it doesn't panic
anymore.

[1]:
https://github.com/ggml-org/llama.cpp/blob/8846aace4/tools/server/README.md#get-v1models-openai-compatible-model-info-api

Signed-off-by: Jean Mertz <git@jeanmertz.com>

Run Details

50 of 58 new or added lines in 2 files covered. (86.21%)

2 existing lines in 1 file now uncovered.

3676 of 9751 relevant lines covered (37.7%)

4.78 hits per line