yeatmanlab / jsCAT / 15909887160

100%

push

github

[ENH] Refactor Clowder's Item Selection and Improve Code Organization (#36)

* Add corpusToSelectFrom parameter

* refactor: improve Clowder item selection

This commit includes several improvements to the Clowder class:

1. Refactor updateCatAndGetNextItem for better organization:
   - Split into clear sections: Validate Input, Update Cats, Early Stopping,
     and Select Item
   - Extract cat updating logic into private _updateCats method
   - Extract item selection logic into private _selectNextItem method
   - Improve code readability with ASCII art section headers

2. Enhance corpusToSelectFrom functionality:
   - Add validation for corpusToSelectFrom parameter
   - Add warning when items lack parameters for both cats
   - Update tests to correctly verify that items need parameters for both
     the selecting cat and target corpus

3. Improve code documentation:
   - Add explanatory comments for non-null assertions
   - Better document the relationship between catToSelect and corpusToSelectFrom

4. Fix code style:
   - Add missing trailing commas
   - Improve formatting consistency

* Add test for warning message when items are available in the corpus but not for catToSelect

290 of 290 branches covered (100.0%)

Branch coverage included in aggregate %.

80 of 80 new or added lines in 1 file covered. (100.0%)

1440 of 1440 relevant lines covered (100.0%)

2047.15 hits per line