supabase / supavisor / 15909153199

65%

push

github

fix: race on tenant startup causing subscribe failure/retry (#678)

Noticed this while starting many connections quickly for a tenant in
local development/testing.

Errors:
```
13:57:34.866 file=lib/supavisor/client_handler.ex line=470 pid=<0.2383.0> project=proxy_tenant1 user=postgres mode=transaction [error] ClientHandler: Subscribe error: {:error, {{:badmatch, {:error, {:already_started, #PID<0.2393.0>}}}, [{Supavisor.TenantSupervisor, :start_link, 1, [file: ~c"lib/supavisor/tenant_supervisor.ex", line: 11]}, {DynamicSupervisor, :start_child, 3, [file: ~c"lib/dynamic_supervisor.ex", line: 800]}, {DynamicSupervisor, :handle_start_child, 2, [file: ~c"lib/dynamic_supervisor.ex", line: 786]}, {:gen_server, :try_handle_call, 4, [file: ~c"gen_server.erl", line: 2381]}, {:gen_server, :handle_msg, 6, [file: ~c"gen_server.erl", line: 2410]}, {:proc_lib, :init_p_do_apply, 3, [file: ~c"proc_lib.erl", line: 329]}]}}

13:57:34.866 file=lib/supavisor/client_handler.ex line=470 pid=<0.2388.0> project=proxy_tenant1 user=postgres mode=transaction [error] ClientHandler: Subscribe error: {:error, {{:badmatch, {:error, {:already_started, #PID<0.2393.0>}}}, [{Supavisor.TenantSupervisor, :start_link, 1, [file: ~c"lib/supavisor/tenant_supervisor.ex", line: 11]}, {DynamicSupervisor, :start_child, 3, [file: ~c"lib/dynamic_supervisor.ex", line: 800]}, {DynamicSupervisor, :handle_start_child, 2, [file: ~c"lib/dynamic_supervisor.ex", line: 786]}, {:gen_server, :try_handle_call, 4, [file: ~c"gen_server.erl", line: 2381]}, {:gen_server, :handle_msg, 6, [file: ~c"gen_server.erl", line: 2410]}, {:proc_lib, :init_p_do_apply, 3, [file: ~c"proc_lib.erl", line: 329]}]}}

13:57:34.866 file=lib/supavisor/client_handler.ex line=470 pid=<0.2381.0> project=proxy_tenant1 user=postgres mode=transaction [error] ClientHandler: Subscribe error: {:error, {{:badmatch, {:error, {:already_started, #PID<0.2393.0>}}}, [{Supavisor.TenantSupervisor, :start_link, 1, [file: ~c"lib/supavisor/tenant_super... (continued)

5 of 6 new or added lines in 1 file covered. (83.33%)

1046 of 2071 relevant lines covered (50.51%)

132.22 hits per line