tari-project / tari / 15898919490
62%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 697
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 71.691% (+0.008%) from 71.683%
15898919490

push

github

web-flow 
fix: ledger builds (#7260)

Description
---
Fixed ledger builds locally using the latest ledger docker image;
however, the objective is to fix the ledger wallet auto-builds in
GitHub, and this may still need some tweaks in follow-up commits.

Motivation and Context
---
Ledger auto-builds in GitHub were failing.

How Has This Been Tested?
---
- Tested locally.
- Ledger auto-builds in GitHub:
https://github.com/hansieodendaal/tari/actions/runs/15869532430

![image](https://github.com/user-attachments/assets/28f139a7-291f-417c-90a9-4751204ed9a8)


What process can a PR reviewer use to test or verify this change?
---
Code review.
Check GitHub actions output.

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **Documentation**
- Updated the README to clarify installation instructions, specify the
correct working directory, and standardize path formatting for commands.

- **Refactor**
- Improved internal handling of string values for "Amount" and
"Receiver" fields to ensure data safety, with no change to visible
behavior.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

82855 of 115572 relevant lines covered (71.69%)

238966.27 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
68.57
 -0.26% base_layer/core/src/mempool/sync_protocol/mod.rs
1
74.51
 -0.08% base_layer/wallet/src/output_manager_service/storage/sqlite_db/mod.rs
1
91.44
 0.0% comms/core/src/peer_manager/peer_storage_sql.rs
2
64.93
 -0.27% comms/dht/src/connectivity/mod.rs
3
90.55
 -0.75% comms/core/src/multiplexing/yamux.rs
4
84.92
 -2.01% comms/core/src/protocol/messaging/outbound.rs
7
56.74
 -0.21% base_layer/wallet/src/transaction_service/service.rs
7
65.67
 -3.0% comms/core/src/protocol/messaging/protocol.rs
Jobs
ID Job ID Ran Files Coverage
1 15898919490.1 697
71.69
 GitHub Action Run
Source Files on build 15898919490