babelfish-for-postgresql / babelfish_extensions / 15776899566

77%

Build Type

push

github

Committed by web-flow

Commit Message

Address issues with arithmetic, mathematical functions for money/smallmoney (#3797)

Handling overflow and incorrect outputs in case of certain money and smallmoney arithmetic and math functions.

There were certain issues found both w.r.t overflow handling and certain functions and operations giving incorrect result for money and smallmoney datatype. This commit addresses those issues.

Issue #1: Overflow of smallmoney arithmetic leading to TDS hang.
Issue #2: Unhandled overflow cases leading to incorrect output.
Issue #3: Fixeddecimal operators being resolved for smallmoney functions and operations leading to incorrect results.

In this commit, we have added new functions for all smallmoney operators and fixed certain overflows with money (fixeddecimal).

New operators added -

arithmetic operators for bit
a. bit and float operators
b. bit and smallmoney operators
c. bit and bit operators.
The reason to introduce bit,bit and bit,float operators is because once we introduced bit,smallmoney; certain operators did not remain unique - like bit, bit and bit, float.
Previously, their output was datetime which was also not valid. Hence, we've corrected the output and introduced these operators.

New functions added -

All arithmetic functions for smallmoney
a. smallmoney and int2, int4 and int8
b. smallmoney and smallmoney
power, ceiling and floor functions for fixeddecimal
Update
we will not be introducing bit, bit operators
Issues Resolved
BABEL-5745, BABEL-5757, BABEL-5756, BABEL-5747, BABEL-5754

Test Scenarios Covered
Note: testcases are imported from PR-3568

---------

Signed-off-by: Ayush Shah <ayushdsh@amazon.com>

Run Details

405 of 439 new or added lines in 3 files covered. (92.26%)

3 existing lines in 2 files now uncovered.

49382 of 65138 relevant lines covered (75.81%)

315751.18 hits per line