kubevirt / containerized-data-importer / #5391

49%

Build Type

push

travis-ci

Committed by web-flow

Commit Message

VEP48: Support architecture specific image import for registry datasource (#3753)

* importer: introduce registry datasource architecture option

This commit introduces preliminary support for a new optional field under the
DV registry source.

The field, platform, has an additional subfield: architecture which
when specified serves as an image index filter to extract a
disk.img only from layers which match it.

If there's a mismatch between requested architecture and
available architectures in the image index the import will fail.

If the requested image is a manifest and not an index the architecture
of the manifest will be compared to the requested architecture and if
they mismatch the import will fail.

API naming has been chosen to mimic the OCI image index spec[1].

[1] https://github.com/opencontainers/image-spec/blob/main/image-index.md#oci-image-index-specification

Signed-off-by: Adi Aloni <aaloni@redhat.com>

* importer: pullMethod node architecture support

This commit adds support for specifying architecture for the registry
data source with pullMethod node. When configured, the importer Pod will
gain another NodeSelector for nodes that have the matching architecture
label.

In the event that the importer Pod is unschedulable due to the
pullMethod node's node selector, the condition will be propagated to the
DV's running condition until it becomes schedulable.

Signed-off-by: Adi Aloni <aaloni@redhat.com>

* docs, image-from-registry: add multi-platform support

Adds a section in the docs about using the platform field for
multi-platform image pull.

Signed-off-by: Adi Aloni <aaloni@redhat.com>

---------

Signed-off-by: Adi Aloni <aaloni@redhat.com>

Run Details

42 of 61 new or added lines in 6 files covered. (68.85%)

4 existing lines in 1 file now uncovered.

16950 of 28528 relevant lines covered (59.42%)

0.66 hits per line