rust-bitcoin / rust-bitcoin / 15762261946

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#4627: units: Make error constructor private

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/f6dea36e313c59c3dca534aba2b7de459f094e9f">f6dea36e3 units: Make error constructor private (Tobin C. Harding)

Pull request description:

  We typically do not want to have public constructors on error types. Currently we do on the `TimeOverflowError` so that we can call it in `primitives` but it turns out we can just use `NumberOf512Seconds` constructors instead.

ACKs for top commit:
  apoelstra:
    ACK f6dea36e313c59c3dca534aba2b7de459f094e9f; successfully ran local tests

Tree-SHA512: f8d4615f2e27d5204f736e85e663c1582ae

Coverage Stats

4 of 4 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

23605 of 27971 relevant lines covered (84.39%)

15825.79 hits per line