Antonboom / testifylint / 15742930669

94%

master: 93%

Pull #248

github

encoded-compare: fix suggestions for JSONEq and YAMLEq

I spotted it by using the following code:

    var foo json.RawMessage
    assert.EqualValues(t, `{"foo": "bar"}`, foo)

that testifylint suggested fixing like this:

    var foo json.RawMessage
    assert.JSONEq(t, `{"foo": "bar"}`, foo)

It's invalid because JSONEq expects strings.

Later, I noticed the code was also suggesting to replace:

    assert.Equal(t, `{"foo": "bar"}`, 42)

with:

    assert.JSONEq(t, `{"foo": "bar"}`, 42)

31 of 31 new or added lines in 2 files covered. (100.0%)

2625 of 2803 relevant lines covered (93.65%)

1.07 hits per line