bitcoindevkit / bdk-cli / 15731603419

8%

push

github

Merge bitcoindevkit/bdk-cli#202: Kyoto: Remove connection requirement to send tx

3b60b7b23 fix(kyoto): remove conn requirement to send tx (rustaceanrob)

Pull request description:

  Kyoto now holds on to a transaction internally until it is successfully broadcast, so we can broadcast the transaction immediately once the node starts up, and wait for a confirmation or 30 second timeout

  Successful test on Signet. Note that `Testnet4` still has the difficulty adjustment bug when loading block headers from storage.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk-cli/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature
  * [ ] I've updated `CHANGELOG.md`

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [ ] I've added tests to reproduce the issue which are now passing
  * [ ] I'm linking the issue being fixed by this PR

Top commit has no ACKs.

Tree-SHA512: e1ad42044cf12ac1738615d6beb8ef424b4

0 of 5 new or added lines in 1 file covered. (0.0%)

25 of 935 relevant lines covered (2.67%)

0.05 hits per line