babelfish-for-postgresql / babelfish_extensions / 15724975994

77%

push

github

fix for incorrect behaviour of patindex function (#3825)

The problem is with the PATINDEX function's behavior when searching for a suffix pattern (pattern at the end of a string).

SELECT PATINDEX('%ing', 'This is a testing string') AS EndPattern

Current behavior:
It returns 15 (matching 'testing'). This is incorrect because we're looking for a suffix match

Expected behavior:
It should return 22 (matching 'string'), because '%ing' should match 'ing' at the end of the string

When we use '%ing' as a pattern, it should specifically match 'ing' when it appears at the end of the string
Instead, it's matching the first occurrence of 'ing' anywhere in the string

Another problem is that when we do a wildcard match i.e when the pattern is '%', function should return the output 1 as in a wildcard match first character will be matched. Current behaviour gives 0 as worng output, fixed that behaviour.

Task: BABEL-5817

Signed-off-by: Pranav Jain pranavjc@amazon.com

3 of 3 new or added lines in 1 file covered. (100.0%)

48884 of 64691 relevant lines covered (75.57%)

317301.75 hits per line