kubernetes-sigs / external-dns / 15693225112

79%

master: 79%

Build Type

Pull #5534

github

Committed by frittentheke

Commit Message

fix: append dot to recordName and target as required by RFC 2782

According to RFC2782 [1], SRV records are to be fully-qualified, ending with a final dot.
Most providers are liberal, but e.g. OpenStack Designate expects the record name and targets
to end with a dot ([2])

Fixes #5476, Fixes #5389, Fixes #5343, Fixes inovex/external-dns-openstack-webhook#50

[1] https://datatracker.ietf.org/doc/html/rfc2782
[2] https://github.com/openstack/designate/blob/698f7b605/designate/tests/unit/objects/test_rrdata_srv.py

Signed-off-by: Christian Rohmann <christian.rohmann@inovex.de>

Pull Request Pull Request #5534: fix: append dot to recordName and target as required by RFC 2782

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

22 existing lines in 1 file now uncovered.

14331 of 18700 relevant lines covered (76.64%)

759.51 hits per line