rust-bitcoin / rust-bitcoin / 15690444566
83%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 130
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 84.328% (+0.02%) from 84.309%
15690444566

push

github

apoelstra 
Merge rust-bitcoin/rust-bitcoin#4616: units: Improve the fee calculation functions

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/0ff8d82193ef562c1aedabe98a6283d09f803c0c">0ff8d8219<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/1fee0755024d7e2785b80b77cf49ca848e7b6ac7"> Make FeeRate from sat constructors infallible (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3b0286bd563f94caae752f1ba6968c9a66b6c85a">3b0286bd5</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/1fee0755024d7e2785b80b77cf49ca848e7b6ac7"> Return NumOpResult for FeeRate and Weight (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/15065b78c782afecc86647283dbb646ddacf217e">15065b78c</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/1fee0755024d7e2785b80b77cf49ca848e7b6ac7"> Return NumOpResult when calculating fee on Amount (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/75106e6d82eb8d9be5f30f944eca91f1c4b061ca">75106e6d8 Remove checked_ prefix from fee functions (Tobin C. Harding)

Pull request description:

  This was https://github.com/rust-bitcoin/rust-bitcoin/commit/14dc950b5 from #4610.

  Remove the `checked_` prefix from `fee` functions then make them all return `NumOpResult`.

ACKs for top commit:
  apoelstra:
    ACK 0ff8d82193ef562c1aedabe98a6283d09f803c0c; successfully ran local tests; nice!

Tree-SHA512: 62f2af670e22c94f7459432ff522bc98aeb

150 of 168 new or added lines in 9 files covered. (89.29%)

3 existing lines in 1 file now uncovered.

23535 of 27909 relevant lines covered (84.33%)

15923.94 hits per line

Uncovered Changes

Lines Coverage ∆ File
12
21.21
 -0.89% units/src/fee_rate/serde.rs
3
89.19
 1.21% units/src/amount/unsigned.rs
2
80.86
 1.22% units/src/fee_rate/mod.rs
1
86.14
 0.07% bitcoin/src/psbt/mod.rs

Coverage Regressions

Lines Coverage ∆ File
3
21.21
 -0.89% units/src/fee_rate/serde.rs
Jobs
ID Job ID Ran Files Coverage
1 15690444566.1 130
84.33
 GitHub Action Run
Source Files on build 15690444566