xapi-project / xen-api / 15685144070
80%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 33
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 77.719%. Remained the same
15685144070

push

github

web-flow 
Fix `xe host-get-cpu-features` command, add `pool-get-cpu-features` (#6513)

`Host.cpu_info` list no longer contains a value associated with
a "features" key, but the CLI implementation was hardcoded to expect it.

As a result, it would show an unhelpful error like:

```
The server failed to handle your request, due to an internal error.
The given message may give details useful for debugging the problem.
message: INTERNAL_ERROR: [ Not_found ]
```

Instead use the `cpu_info_features` keys from xapi-consts (after moving
these keys from xapi-globs first).

Add the pool version of the command.

Additionally document their output format:

```
# xe help host-get-cpu-features
command name            : host-get-cpu-features
        reqd params     :
        optional params : uuid
        description     : Prints a hexadecimal representation of the host's physical-CPU
           features for PV and HVM VMs. features_{hvm,pv} are "maximum"
           featuresets the host will accept during migrations, and
           features_{hvm,pv}_host will be used to start new VMs.

# xe help pool-get-cpu-features
command name            : pool-get-cpu-features
        reqd params     :
        optional params :
        description     : Prints a hexadecimal representation of the pool's physical-CPU
           features for PV and HVM VMs. These are combinations of all the
           hosts' policies and are used when starting new VMs in a pool.

# xe host-get-cpu-features uuid=7f566729-0ee7-47c4-853d-2c5f3a195ad4
features_pv          : 1fc9cbf5-f6f83203-2991cbf5-00000123-00000001-000c0b39-00000000-00000100-00001000-ac000c00-00000000-00000000-00000000-00000000-00000000-00000000-1c020004-00000000-00000000-00000000-00000000-00000000
         features_hvm: 1fcbfbff-f7fa3223-2d93fbff-00000523-00000001-001c0fbb-00000000-00000100-00101000-bc000c00-00000000-00000000-00000000-00000000-00000000-00000000-1c020004-00000000-00000000-00000000-00000000-00000000
     features_pv_host: 1fc9... (continued)

3359 of 4322 relevant lines covered (77.72%)

0.78 hits per line

Jobs
ID Job ID Ran Files Coverage
1 python3.11 - 15685144070.1 33
77.72
 GitHub Action Run
Source Files on build 15685144070