FlexMeasures / flexmeasures / 15657318002

74%

push

github

Expand can_modify_role util function to cover which user is modified - improving authorization checks (#1517)

* refactor: explan can_modify_role util function to cover more validation cases

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

* fix: fixed issue with failing test

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

* refactor: removed extra conditions

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

* refactor: made util function more conscise

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

* ref: avoiding double negatives in util function

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

* refactor: re order conditional checks

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

* remove not needed braces

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* remove unneeded check for admin role change (cannot be changed here) and improve docstring

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* add changelog entry

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* turns out the admin-reader check (to allow admins to change them) was not needed

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

---------

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Co-authored-by: Nicolas Höning <nicolas@seita.nl>

4059 of 6984 branches covered (58.12%)

Branch coverage included in aggregate %.

15 of 15 new or added lines in 2 files covered. (100.0%)

8688 of 11966 relevant lines covered (72.61%)

7.15 hits per line