rust-bitcoin / rust-bitcoin / 15641044805

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4615: Remove reachable unreachable call in psbt

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/e7c90c57e7b5ee20a2c523706cc4ea9957594857">e7c90c57e<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/052514e6ffb987773221099a2d9ba5b1d02ff071"> Remove reachable unreachable call in psbt (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/c736e73ae020f80a29bf6dce7d6b7741df42e679">c736e73ae</a> Add unwrap_or and unwrap_or_else to NumOpResult (Tobin C. Harding)

Pull request description:

  A bunch of changes have been implemented lately in the fee calculation logic. As a result of this a at once time `unreachable` statement is now reachable - bad rust-bitcoin devs, no biscuit.

  Saturate to `FeeRate::MAX` when calculating the fee rate, check against the limit arg, and win.

  (Patch 1 adds the new combinators to `NumOpResult`. This was pulled out of #4610.)

ACKs for top commit:
  apoelstra:
    ACK e7c90c57e7b5ee20a2c523706cc4ea9957594857; successfully ran local tests

Tree-SHA512: d33b3d5d46c6923744d2f0201157486bbb4

8 of 17 new or added lines in 2 files covered. (47.06%)

23536 of 27916 relevant lines covered (84.31%)

15940.2 hits per line