Qiskit / qiskit / 15639327496

88%

main: 88%

Build Type

push

github

Committed by web-flow

Commit Message

Fix random number generator seed argument for quantum_volume (#14586) (#14592)

* Fix random number generator seed argument for quantum_volume

The `seed` argument to `quantum_volume` being a `numpy.random.Generator`
resulted in `integers` being called with 0 for the `low` argument. When
called with only a `low` argument like this, this value is taken as one
more than the maximum and 0 is treated as the minimum. This resulted in a
`TypeError` because the range is from 0 to -1. Here the handling of
`Generator` was updated to match how the deprecated `QuantumVolume`
class handled `seed` (which was slightly odd -- it caps the range at the
int64 limit even though the argument is a `u64` in the Rust function --
but probably fine; keeping the range helps keep the behavior consistent
between `QuantumVolume` and `quantum_volume` for a generator with the
same seed).

* Address pylint's misunderstanding of the test import

(cherry picked from commit ba74b5c47)

Co-authored-by: Will Shanks <willshanks@us.ibm.com>

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

22 existing lines in 3 files now uncovered.

83029 of 94374 relevant lines covered (87.98%)

517188.06 hits per line