toml-rs / toml / 15617360202

81%

Build Type

push

github

Committed by web-flow

Commit Message

feat(toml)!: Replace `toml_edit` with `toml_parse` (#945)

This adds `toml::de::DeTable`, `toml::de::DeValue`,
`toml::de::DeString`, and `toml::de::DeArray` which are borrowed,
spanned data structures for parsing into that we then support
deserializing from. Due to the nature of TOML (a `Map`s keys are
intermixed with descendant and parent `Map` keys through dotted keys,
standard table ordering, error reporting requirements), we can't
directly deserialize from the parsed result.

This also adds `IntoDeserializer` for `Deserializer` /
`ValueDeserializer`.

BREAKING CHANGE: `ValueDeserializer::new` was replaced with
`ValueDeserializer::parse` and can return an error.

BREAKING CHANGE: `Deserialize::new` was replaced with
`Deserializer::parse` and can return an error.

For the porting of `toml_edit` to `toml_parse`, see #922 

For the introduction of `toml_parse`, see #891

## Benchmarks

Notes:
- A big difference between v0.8.23 and `main` is #922
- `preserve_order` only affected `toml::Table`, so the older "document"
benchmarks for `toml` will parse into an `IndexMap` (from `toml_edit`)
and then deserialize into either a `BTreeMap` or an `IndexMap` while
`de` will parse and deserialize into either a `BTreeMap` or an
`IndexMap`
- `manifest` deserializes into a `struct`, avoiding at least a top-level
`*Map` creation and avoid allocations of some keys.

**0_cargo::toml::document::2-features**

| parser  | features               |  time |
|------------|-------------------------|---------|
| v0.5      |                                | 1032us |
| v0.5      | `preserve_order` | 924us |
| v0.8.23 |                                |  745us |
| `main`   |                                | 697us |
| `main`   | `preserve_order` | 589us |
| `de`       |                                | 702us |
| `de`       | `preserve_order` | 464us |
| `de`       | `unsafe`                | 706us |
| `de`       | `simd`                    | 702us |
| `de`       | all               ... (continued)

Run Details

734 of 1190 new or added lines in 22 files covered. (61.68%)

7 existing lines in 4 files now uncovered.

6185 of 8910 relevant lines covered (69.42%)

6.87 hits per line