• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In
Warning: This build has drifted.
The coverage report for this pull request build may be inaccurate because its base commit is no longer the HEAD of its target branch.
This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

    • Learn more: For more information on this, see Tracking coverage changes for pull request builds.
    • Fix now: For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
    • Prevent going forward: To avoid this issue with future PRs, see these Recommended CI Configurations.
New Repo Setting:
INCLUDE COVERAGE % WITH WARNINGS ABOUT DRIFTED BUILDS?

Enabling this setting will include a (potentially inaccurate) coverage % with warning messages in status updates for drifted builds.

Adjust setting

sapcc / limes / 15612395182
79%
master: 80%

Build:
Build:
LAST BUILD BRANCH: gomm-remove-coveralls
DEFAULT BRANCH: master
Ran 12 Jun 2025 01:51PM UTC
Jobs 1
Files 68
Run time 239min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

12 Jun 2025 01:41PM UTC coverage: 79.172% (+0.05%) from 79.123%
15612395182

Pull #730

github

majewsky
add UUID field to commitments

It is a historical mistake of mine that we exposed numerical IDs on
commitments in the first place. We should have UUIDs here to avoid
exposing the number of commitments to non-privileged users, and as
defense in depth against enumeration attacks.

Because commitments of some sort will start appearing in LIQUID soon,
I want to right this wrong before it seeps into the LIQUID API. LIQUID
will only ever refer to commitments by UUID, and the Limes v2 API will
also move to only using UUIDs. The v1 API will show both identifiers to
aid in the migration.

For tests, a facility is added to generate UUIDs in deterministic ways,
similar to what we already have for commitment transfer tokens.

An additional complication presents itself in type
CommitmentWorkflowContext: Currently, commitments refer to other
commitments by numerical ID here. I'm adding UUIDs here on top of the
existing RelatedIDs field, with the intention of eventually fully
replacing RelatedIDs with RelatedUUIDs. However, we will need a
migration period here: We cannot backfill existing contexts with the
UUIDs of the related commitments, since some of those superseded or
expired commitments have already been garbage-collected from the DB.
Pull Request #730: add UUID field to commitments

61 of 66 new or added lines in 5 files covered. (92.42%)

6481 of 8186 relevant lines covered (79.17%)

49.36 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
5
35.29
-14.71% internal/api/utils.go
Jobs
ID Job ID Ran Files Coverage
1 15612395182.1 12 Jun 2025 01:51PM UTC 68
79.17
GitHub Action Run
Source Files on build 15612395182
  • Tree
  • List 68
  • Changed 7
  • Source Changed 0
  • Coverage Changed 7
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Pull Request #730
  • PR Base - master (#15588308042)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc