safe-global / safe-smart-account / 15586606165

94%

push

github

ZKSync Package Update (#985)

This pull request includes updates to dependencies in `package.json` and
refactors multiple test files to improve code readability and ensure
proper handling of asynchronous operations. The most important changes
involve upgrading dependencies, adding `.then(tx => tx.wait(1))` for
transaction handling, and simplifying assertions in test cases.

### Dependency Updates:
*
[`package.json`](diffhunk://#diff-7ae45ad106470d7bc6507b6481575d519L65-R67):
Upgraded versions of `@matterlabs/hardhat-zksync-node`,
`@matterlabs/hardhat-zksync-solc`, and
`@matterlabs/hardhat-zksync-verify` to ensure compatibility with the
latest features and bug fixes.

### Test Refactoring:
#### Transaction Handling:
*
[`test/core/Safe.Setup.spec.ts`](diffhunk://#diff-3a0450acfb748d05bbea12c3aee337eb3L365-R371):
Added `.then(tx => tx.wait(1))` to transaction calls like
`template.setup` for proper handling of asynchronous operations.
*
[`test/factory/ProxyFactory.spec.ts`](diffhunk://#diff-<a class=hub.com/safe-global/safe-smart-account/commit/<a class="double-link" href="https://git"><a class=hub.com/safe-global/safe-smart-account/commit/15ca4038d34d698512d5f3504c572695a5094d5d">15ca4038d647fd3b3b2e2503d50de4230L302-R302):
Refactored `createChainSpecificProxyWithNonce` and
`createChainSpecificProxyWithNonceL2` calls to include `.then(tx =>
tx.wait(1))`.
[[1]](diffhunk://#diff-15ca4038d34d698512d5f3504c572695a5094d5d647fd3b3b2e2503d50de4230L302-R302)
[[2]](diffhunk://#diff-15ca4038d34d698512d5f3504c572695a5094d5d647fd3b3b2e2503d50de4230L413-R413)
*
[`test/integration/Safe.0xExploit.spec.ts`](diffhunk://#diff-<a class=hub.com/safe-global/safe-smart-account/commit/<a class="double-link" href="https://git"><a class=hub.com/safe-global/safe-smart-account/commit/54d6c48032249262740b581863a899b6f42852b2">54d6c480321b3aef0bb88bae4e7a286dcL84-R87):
Updated transaction calls such as `safe.execTransaction` and
`user1.sendTransaction` to include `.then(tx => tx.wait(1))`.
[[1]](diffhunk://#diff-54d6c48032249262740b581863a899b6f42852b221b3aef0bb88bae4e7a286dcL84-R87)
[[2]](diffhunk://#diff-54d6c48032249262740b581863a899b6f42852b221b3aef0bb88bae4e7a286dcL119-R123)

#### Simplified Assertions:
*
[`test/integration/Safe.0xExplo... (continued)

327 of 368 branches covered (88.86%)

Branch coverage included in aggregate %.

491 of 503 relevant lines covered (97.61%)

104.17 hits per line