tarantool / luajit / 15559377869

93%

tarantool/master: 93%

Build Type

push

github

Committed by Buristan

Commit Message

Fix another potential file descriptor leak in luaL_loadfile*().

Reported by Peter Cawley.

(cherry picked from commit ab39082fd)

`loadfile()` doesn't close the fd in case when `fopen()` results
successfully, but then the file can't be read (since it is a directory,
for example) or parser failure occurs for some reason.

This patch fixes that behaviour by moving the error formatting after the
cleanup of the descriptor.

Sergey Kaplun:
* added the description and the test for the problem

Part of tarantool/tarantool#11278

Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org>
Signed-off-by: Sergey Kaplun <skaplun@tarantool.org>
(cherry picked from commit 7035dc49b)

Run Details

5710 of 6044 branches covered (94.47%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

21795 of 23507 relevant lines covered (92.72%)

3834186.51 hits per line