15557724256
80%

Ran 10 Jun 2025 11:03AM UTC

Jobs 1

Files 33

Run time 1min

Badge

Embed ▾

Committed 10 Jun 2025 10:44AM UTC coverage: 77.719%. Remained the same

Build # 15557724256

Build Type

push

github

Committed by

web-flow

Commit Message

Make rrdd more robust against domain appearing and disappearing (#6515)

Currently rrdd needs to know when a metric comes from a new domain,
(after a
local migration, for example). This is because when a new domain is
created the
counters start from zero again, and so this needs special logic to
handle when
aggregating the metrics into rrds.

Previously rrdd collected this information before metrics were
collected, this means that metrics collected by plugins could be be lost
if the
domain was created in that small amount of time, or if the domain was
destroyed
after a plugin collected data about it.

With the current change the domains are collected every loop and added
to the
domains collected in the previous loop to avoid missing any newly
created or
destroyed domains. The current iteration only gets fed data from the
last
iteration to avoid accumulating all domains seen since the start of
xcp-rrdd.

With this done it's now safe to move the host and memory metrics
collection
into its own plugin.

Also use sequences more throroughly in the code for transformations

I've manually tested this change by repeatedly by single-host
live-migrating a VM and checking that no beats are missed on the graphs.
![Screenshot 2025-06-09 at 15 55
54](https://github.com/user-attachments/assets/8d5dea0a-a1aa-4a49-a712-9512e18036cc)

Run Details

3359 of 4322 relevant lines covered (77.72%)

0.78 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	python3.11 - 15557724256.1	10 Jun 2025 11:03AM UTC	33	77.72	GitHub Action Run

xapi-project / xen-api / 15557724256
80%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 15557724256

xapi-project / xen-api / 15557724256 80%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 15557724256

xapi-project / xen-api / 15557724256
80%

README BADGES
x