payjoin / rust-payjoin / 15546580180

83%

Build Type

push

github

Committed by web-flow

Commit Message

Simplify v1 response processing function signatures (#745)

This was prompted by the discussion in
https://github.com/payjoin/rust-payjoin/pull/710#discussion_r2104814421.

Using a reader still left callers susceptible to writing memory
exhaustion vulnerable code, and just introduced extra complexity by
having to buffer twice. We can recognize this and leave the buffering
entirely up to the caller. Also, the V2 sender and receiver response
processing functions already take &[u8], so this makes the function
signatures more consistent across versions.

Run Details

31 of 34 new or added lines in 6 files covered. (91.18%)

2 existing lines in 2 files now uncovered.

6973 of 8158 relevant lines covered (85.47%)

568.98 hits per line