kubevirt / hyperconverged-cluster-operator / 15518829868

76%

Build Type

push

github

Committed by web-flow

Commit Message

Fix issues with ingress-controller (#3554)

This PR fixes two bugs at the ingress-cluster-controller of HCO:
1. If the reconciliation completed before HyperConverged CR is created, and then the CR is created, the ingress-controller reconciliation is not triggered and thus the virt-downloads ComponentRoute is not added to the ingresses.config.openshift.io CR. This causes a test failure of 'should allow download URL customisation'. The fix is to add a watch of this controller for the HyperConverged CR, on creation and deletion.
2. When the HyperConverged CR is deleted, the virt-downloads ComponentRoute is deleted from the ingresses.config.openshift.io status, and then the ingress-controller tries to update conditions on non-existent entry, resulting in panic in the reconciliation loop. The fix is to not set conditions if the CR was deleted.

Signed-off-by: Oren Cohen <ocohen@redhat.com>

Run Details

26 of 46 new or added lines in 1 file covered. (56.52%)

1 existing line in 1 file now uncovered.

6562 of 8976 relevant lines covered (73.11%)

0.96 hits per line