kubeflow / trainer / 15495828259

push

github

feat(controller): Implement PodSpecOverride API (#2614)

* feat(controller): Implement PodSpecOverride API

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Update API comments

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Fix InitContainers override

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Fix generate

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Update pkg/apis/trainer/v1alpha1/trainjob_types.go

Co-authored-by: Shao Wang <2690692950@qq.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Change API to targetJob and add validation

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Add unit test for the JobSet builder

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Add integration tests

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Update pkg/apis/trainer/v1alpha1/trainjob_types.go

Co-authored-by: Shao Wang <2690692950@qq.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Update pkg/apis/trainer/v1alpha1/trainjob_types.go

Co-authored-by: Shao Wang <2690692950@qq.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Update pkg/apis/trainer/v1alpha1/trainjob_types.go

Co-authored-by: Antonin Stefanutti <astefanutti@users.noreply.github.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Merge PodSpecOverrides before the build phase

Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr>

* Fix make generate

Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr>

* Fix PodSpec SMT patch unmarshalling into JobSet template

Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr>

* Add UT for volumes PodSpecOverrides

Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr>

* Add UT for tolerations PodSpecOverrides

Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr>

* Add UT for ... (continued)

47 of 136 new or added lines in 3 files covered. (34.56%)

887 of 3051 relevant lines covered (29.07%)

0.34 hits per line