kubeflow / trainer / 15495828259
51%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 31
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 29.072% (+0.3%) from 28.807%
15495828259

push

github

web-flow 
feat(controller): Implement PodSpecOverride API (#2614)

* feat(controller): Implement PodSpecOverride API

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Update API comments

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Fix InitContainers override

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Fix generate

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Update pkg/apis/trainer/v1alpha1/trainjob_types.go

Co-authored-by: Shao Wang <2690692950@qq.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Change API to targetJob and add validation

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Add unit test for the JobSet builder

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Add integration tests

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Update pkg/apis/trainer/v1alpha1/trainjob_types.go

Co-authored-by: Shao Wang <2690692950@qq.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Update pkg/apis/trainer/v1alpha1/trainjob_types.go

Co-authored-by: Shao Wang <2690692950@qq.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Update pkg/apis/trainer/v1alpha1/trainjob_types.go

Co-authored-by: Antonin Stefanutti <astefanutti@users.noreply.github.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Merge PodSpecOverrides before the build phase

Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr>

* Fix make generate

Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr>

* Fix PodSpec SMT patch unmarshalling into JobSet template

Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr>

* Add UT for volumes PodSpecOverrides

Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr>

* Add UT for tolerations PodSpecOverrides

Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr>

* Add UT for ... (continued)

47 of 136 new or added lines in 3 files covered. (34.56%)

4 existing lines in 2 files now uncovered.

887 of 3051 relevant lines covered (29.07%)

0.34 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
2
50.0
 9.7% pkg/runtime/framework/plugins/jobset/jobset.go
10
70.76
 -0.87% pkg/runtime/core/trainingruntime.go
77
0.0
 0.0% pkg/util/testing/wrapper.go

Uncovered Existing Lines

Lines Coverage ∆ File
2
0.0
 0.0% pkg/runtime/framework/plugins/jobset/builder.go
2
0.0
 0.0% pkg/util/testing/wrapper.go
Jobs
ID Job ID Ran Files Coverage
1 0 - 15495828259.1 31
29.07
 GitHub Action Run
Source Files on build 15495828259